Add support for coloring pointclouds by distance #6938
Conversation
|
@IvDmNe is attempting to deploy a commit to the Foxglove Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Thanks for the PR and sorry for the delay in response. I think we are in favor of adding this feature. My main concern is that the "<distance>" string is being appended to a list of field names that come from user data, so in the rare event there is a conflict, that would cause problems. I would suggest that you actually add a new field to the config, maybe something like config.colorFieldComputed: "distance" | undefined. Then it becomes possible to disambiguate this special computed value from any user-defined point cloud field. The colorFieldOptions can still be a combination of user-defined and computed options, but the value of each option can be prefixed to avoid conflicting with a value of "distance".
Re translation, the option label can be translated, e.g. t("colorFieldDistance") and then add colorFieldDistance: "<distance>" to i18n/en/threeDee.ts.
You should also be able to add an entry to foxglove.PointCloud.stories.tsx to demonstrate the new functionality in a screenshot test.
… config field ColorFieldComputed and translation string for option to compute distance in ColorBy list
|
I have done as you suggested: automatically computed distance option now has prefix If everything is alright, I will start to add the story. |
IvDmNe
changed the title
|
👍 great feature |
User-Facing Changes
Added option to color points in 3D and Image panels by norm of their coordinates.
Description
I added a ColorFieldOption "<distance>" and a new reader function for packedColorReader that uses 3 another readers for X, Y, Z coordinates and returns norm of these values.
I am not sure about one moment - should "<distance>" option be added in such hardcoded way or the name should be some variable to support translation to another languages?